Yes good to fix dev-support/run-source-ratcheck.sh (i also used the same). On Tue, Jul 12, 2022 at 12:34 PM Istvan Toth <[email protected]> wrote:
> This vote has failed, I'm going to prepare RC1 with the license fix, and > start a new vote. > > Thanks to everyone who voted, especially to Richard who found the license > problem. > (The run-source-ratcheck.sh script omits the files in root directory, we > should fix that as well) > > Istvan > > On Tue, Jul 12, 2022 at 2:03 PM Richard Antal > <[email protected]> wrote: > > > -1 > > > > Signature OK > > > > checksum OK > > > > ran test - OK > > > > mvn clean apache-rat:check fails > > > > Files with unapproved licenses: > > python-phoenixdb/docker-entrypoint.sh > > > > > > > https://github.com/apache/phoenix-queryserver/blob/python-phoenixdb-1.2.0.rc0/python-phoenixdb/docker-entrypoint.sh > > < > > > https://github.com/apache/phoenix-queryserver/blob/python-phoenixdb-1.2.0.rc0/python-phoenixdb/docker-entrypoint.sh > > > > > > > > > Richard > > > > On Tue, Jul 12, 2022 at 5:34 AM Viraj Jasani <[email protected]> wrote: > > > > > +1 > > > > > > * Rat check: ok > > > * Ran all the tests using toxtext on docker, with python 2.7 and 3.5+ > > > versions (including 3.9 and 3.10), all good. > > > * setup.py includes 1.2.0 > > > > > > Thanks for all the help with this release, Istvan! > > > > > > > > > On Wed, Jun 22, 2022 at 1:52 AM Istvan Toth <[email protected]> wrote: > > > > > > > Hello Everyone, > > > > > > > > This is a call for a vote on phoenixdb 1.2.0 RC0. > > > > > > > > PhoenixDB is native Python driver for accessing Phoenix via Phoenix > > Query > > > > Server. > > > > > > > > This version contains the following improvements compared to the > > previous > > > > 1.1.0 release > > > > > > > > - Updated test environment to support Python 3.9 and 3.10 > > (PHOENIX-6737) > > > > - Fixed get_view_names() in SqlAlchemy driver (PHOENIX-6727) > > > > - Added supports_statement_cache attribute for SqlAlchemy dialect to > > > avoid > > > > warnings (PHOENIX-6735) > > > > - Re-generated the protobuf Python files with protoc 3.19 from the > > > Avatica > > > > 1.21 descriptors (PHOENIX-6731) > > > > - Dropped support for Python 3.4 (PHOENIX-6731) > > > > > > > > The source release consists of the contents of the python-phoenixdb > > > > directory of the phoenix-queryserver repository. > > > > > > > > The source tarball, including signatures, digests, etc can be found > at: > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/python-phoenixdb-1.2.0.rc0/ > > > > > > > > Artifacts are signed with my "CODE SIGNING KEY": > > > > 825203A70405BC83AECF5F7D97351C1B794433C7 > > > > > > > > KEYS file available here: > > > > https://dist.apache.org/repos/dist/dev/phoenix/KEYS > > > > > > > > > > > > The hash and tag to be voted upon: > > > > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=phoenix-queryserver.git;a=commit;h=bd1b36987912f20f1074e93caf257397111b8e9f > > > > > > > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=phoenix-queryserver.git;a=tag;h=refs/tags/python-phoenixdb-1.2.0.rc0 > > > > > > > > The vote will be open for at least 72 hours. Please vote: > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove (and reason why) > > > > > > > > Thanks, > > > > Istvan > > > > > > > > > > > > -- > *István Tóth* | Staff Software Engineer > [email protected] <https://www.cloudera.com> > [image: Cloudera] <https://www.cloudera.com/> > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera > on LinkedIn] <https://www.linkedin.com/company/cloudera> > <https://www.cloudera.com/> > ------------------------------ >
