[
https://issues.apache.org/jira/browse/OMID-223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580268#comment-17580268
]
ASF GitHub Bot commented on OMID-223:
-------------------------------------
stoty commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r946664347
##########
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##########
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
*/
private boolean skipCellVersion(Cell cell) {
return skipColumn != null
- && CellUtil.matchingRow(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
+ && PrivateCellUtil.matchingRows(cell, skipColumn.getRowArray(),
skipColumn.getRowOffset(),
Review Comment:
Most of the server-side HBase Cell API is Private, which I think is a
mistake.
It should be Limited for coprocessor usage.
There is no way Phoenix can operate without those classes.
I think that in this case, making an exception for PrivateCellUtil is fine.
WDYT @gjacoby126 ?
> Refactor Omid to use HBase 2 APIs internally.
> ---------------------------------------------
>
> Key: OMID-223
> URL: https://issues.apache.org/jira/browse/OMID-223
> Project: Phoenix Omid
> Issue Type: Improvement
> Reporter: Istvan Toth
> Assignee: Aron Attila Meszaros
> Priority: Major
> Attachments: OMID-223-wip.patch
>
>
> Omid currently uses HBase 1 APIs everywhere.
> This made sense when HBase 1 and 2 had to be supported from the same codebase.
> However, as we're dropping HBase 1 support, this is a liability now.
> Doing this is also going to eventually make supporting HBase 3 much easier.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
