[ 
https://issues.apache.org/jira/browse/OMID-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767181#comment-17767181
 ] 

Istvan Toth commented on OMID-237:
----------------------------------

My proposed fix is just a simple hack to use a different value that doesn't 
seem to be set by some previous test.

The proper fix would be resetting the test system between tests, but that would 
be both more work and slow down the test suite.

> TestHBaseTransactionClient.testReadCommitTimestampFromCommitTable fails
> -----------------------------------------------------------------------
>
>                 Key: OMID-237
>                 URL: https://issues.apache.org/jira/browse/OMID-237
>             Project: Phoenix Omid
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> On my machine, 
> TestHBaseTransactionClient.testReadCommitTimestampFromCommitTable failed in 3 
> out of 3 runs.
> {noformat}
> [ERROR] Tests run: 95, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 
> 341.56 s <<< FAILURE! - in TestSuite
> [ERROR] 
> testReadCommitTimestampFromCommitTable(org.apache.omid.transaction.TestHBaseTransactionClient)
>   Time elapsed: 0.025 s  <<< FAILURE!
> java.lang.AssertionError: expected [false] but found [true]
>     at org.testng.Assert.fail(Assert.java:94)
>     at org.testng.Assert.failNotEquals(Assert.java:513)
>     at org.testng.Assert.assertFalse(Assert.java:63)
>     at org.testng.Assert.assertFalse(Assert.java:73)
>     at 
> org.apache.omid.transaction.TestHBaseTransactionClient.testReadCommitTimestampFromCommitTable(TestHBaseTransactionClient.java:144)
>     at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native 
> Method)
>     at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>     at 
> org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
>     at 
> org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
>     at 
> org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
>     at 
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
>     at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>     at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>     at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>     at java.base/java.lang.Thread.run(Thread.java:829){noformat}
> I don't see this failure on the CI, so this is possibly a timing issue 
> related to the host performance (or maybe the CI tests are just failing 
> earlier)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to