Hi Istvan, TIL ... I never even thought about doing it that way to be honest :) I just browsed a few open source repos and among the few who do release candidates it seems to be about a fifty:fifty split whether they change the version number or not.
It is not an issue for us though, this was just an experiment to see how much better 1.1.1 performs regarding CVEs than 1.1.0 and I didn't want to wait for the actual release. Usually we won't be building any non-release versions. Best, Sönke On Fri, Feb 2, 2024 at 8:55 PM Istvan Toth <st...@cloudera.com.invalid> wrote: > As eventually an RC is released as final without any changes, there is no > way around this issue. > > The RC artifacts must always identify as the final version. > This is why RCs are not pushed to regular repos. > > If you want to use non-final versions, you can try building from git HEAD. > > Istvan > > > On Fri, Feb 2, 2024 at 3:25 PM Sönke Liebau > <soenke.lie...@stackable.tech.invalid> wrote: > > > Hi all, > > > > I just tested 1.1.1RC1 with our CI to create a docker image of it and > > noticed that while it is an RC version, the Maven version has been set to > > 1.1.1 instead of 1.1.1RC1. [1] > > > > This created issues in our CI because I had to specify the version as > > 1.1.1RC1 to download the correct file, but mvn package wrote > > "omid-tso-server-1.1.1-bin.tar.gz" and the subsequent step that wanted to > > copy "omid-tso-server-1.1.1RC1-bin.tar.gz" failed. But that is only a > > minor annoyance that could be fixed in our CI chain. > > > > The larger issue I see is, that no one will be able to distinguish > between > > an actually released artifact and a release candidate later on. > > > > I wanted to ask if this is intentional or maybe just an oversight, before > > opening an issue.. > > > > Best regards, > > Sönke > > > > [1] > > > > > https://github.com/apache/phoenix-omid/blob/edc79fc3038d326c811ffe342bafccd9245c4ef7/pom.xml#L30 > > > > > -- > *István Tóth* | Sr. Staff Software Engineer > *Email*: st...@cloudera.com > cloudera.com <https://www.cloudera.com> > [image: Cloudera] <https://www.cloudera.com/> > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera > on LinkedIn] <https://www.linkedin.com/company/cloudera> > ------------------------------ > ------------------------------ >
