Thanks Istvan! With very limited bandwidth, I might merge your changes sooner and give another RC a try.
However, if you find the PR still open, please feel free to merge and port to 5.2 branch. On Thu, Oct 10, 2024 at 12:22 AM Istvan Toth <st...@cloudera.com.invalid> wrote: > -0 (binding) > > I have found another problem when compiling with HBase 2.6.1 > > https://issues.apache.org/jira/browse/PHOENIX-7423 > > This does not stop the binaries from working with 2.6.1, but this would be > a problem for anyone trying to compile 5.2.1 with Hbase 2.6.1 or later, > (and probably also any upcoming Hbase 2.5 patch releases) > IMO being able to compile 5.2.1 with the 2.6.1 is worth another RC > (especially as it's not me who has to prepare it :) ) > > > > > > On Wed, Oct 9, 2024 at 2:23 PM Istvan Toth <st...@cloudera.com> wrote: > > > +1 (binding) > > > > Checksum: OK > > Signature: OK > > ran full test suite with JVM8+HBase 2.4, only the usual flaky tests have > > failed : OK > > ran full test suite with JVM8+HBase 2.5, only the usual flaky tests have > > failed : OK > > ran full test suite with JVM17+HBase 2.6, only the usual flaky tests have > > failed : OK > > mvn apache-rat:check: OK > > eyeballed release notes and changelog: OK > > > > best regards > > Istvan > > > > On Sat, Oct 5, 2024 at 8:38 PM Viraj Jasani <vjas...@apache.org> wrote: > > > >> Please vote on this Apache Phoenix release candidate, Phoenix-5.2.1RC4 > >> > >> The VOTE will remain open for at least 72 hours. > >> > >> [ ] +1 Release this package as Apache Phoenix 5.2.1 > >> [ ] -1 Do not release this package because ... > >> > >> The tag to be voted on is 5.2.1RC4: > >> > >> https://github.com/apache/phoenix/tree/5.2.1RC4 > >> > >> The release files, including signatures, digests, as well as CHANGES.md > >> and > >> RELEASENOTES.md included in this RC can be found at: > >> > >> https://dist.apache.org/repos/dist/dev/phoenix/phoenix-5.2.1RC4/ > >> > >> Maven artifacts are available in a staging repository at: > >> > >> > https://repository.apache.org/content/repositories/orgapachephoenix-1261/ > >> > >> Artifacts were signed with the 1012D134 key which can be found in: > >> > >> https://dist.apache.org/repos/dist/release/phoenix/KEYS > >> > >> To learn more about Apache Phoenix, please see > >> > >> https://phoenix.apache.org/ > >> > >> Thanks, > >> Your Phoenix Release Manager > >> > > > > > > -- > > *István Tóth* | Sr. Staff Software Engineer > > *Email*: st...@cloudera.com > > cloudera.com <https://www.cloudera.com> > > [image: Cloudera] <https://www.cloudera.com/> > > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: > > Cloudera on LinkedIn] <https://www.linkedin.com/company/cloudera> > > ------------------------------ > > ------------------------------ > > > > > -- > *István Tóth* | Sr. Staff Software Engineer > *Email*: st...@cloudera.com > cloudera.com <https://www.cloudera.com> > [image: Cloudera] <https://www.cloudera.com/> > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera > on LinkedIn] <https://www.linkedin.com/company/cloudera> > ------------------------------ > ------------------------------ >