[ 
https://issues.apache.org/jira/browse/PHOENIX-7597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sanjeet Malhotra moved HBASE-29278 to PHOENIX-7597:
---------------------------------------------------

        Key: PHOENIX-7597  (was: HBASE-29278)
    Project: Phoenix  (was: HBase)

> Replace isEmptyColumn in CompactionScanner with equivalent method from HBase 
> CellUtil
> -------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-7597
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7597
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Sanjeet Malhotra
>            Priority: Minor
>
> Currently we have following utility method defined in Phoenix:
> {code:java}
> public static boolean isEmptyColumn(Cell cell, byte[] emptyCF, byte[] 
> emptyCQ) {
>         return CellUtil.matchingFamily(cell, emptyCF, 0, emptyCF.length) &&
>                CellUtil.matchingQualifier(cell, emptyCQ, 0, emptyCQ.length);
> } {code}
> Firstly this method gives an impression based on its name that it knows about 
> emptyCF and emptyCQ while it is only comparing column family and column 
> qualifier against provided `emptyCF` and `emptyCQ`.
> Also, there is an equivalent method in HBase CellUtil:
> {code:java}
> public static boolean matchingColumn(final Cell left, final byte[] fam, final 
> byte[] qual) {
>   return matchingFamily(left, fam) && matchingQualifier(left, qual);
> } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to