[ 
https://issues.apache.org/jira/browse/PHOENIX-7676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nihal Jain updated PHOENIX-7676:
--------------------------------
    Description: 
{quote}For the changes where spotless checks are being applied, it is failing 
checkstyle validation.
Checkstyle validation failure :
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2238/2/artifact/yetus-general-check/output/results-checkstyle-phoenix-core-client.txt
{quote}
Ref: https://lists.apache.org/thread/9gbh5xs544h4q4w4xt64oy9osy8g8f81

Confirmed same:
Before, with commit#67d47a612e745cf7f21a8522eb92209c4c43784f:
{code:java}
phoenix % grep 'There [are|is]' 67d47a612e745cf7f21a8522eb92209c4c43784f.txt 
[INFO] There are 13 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.6.0/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 13 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.5.4/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 13 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.5.0/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 13 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.4.1/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 33260 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-core-client/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 8727 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-core-server/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 1113 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-pherf/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 209 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-tracing-webapp/../src/main/config/checkstyle/checker.xml
 ruleset.
{code}


After, with commit#f305a5c532d8e7693b7f14361d7b54a346a77ce6:

{code:java}
phoenix % grep 'There [are|is]' master.txt  
[INFO] There are 197 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.6.0/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 196 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.5.4/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 193 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.5.0/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 189 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.4.1/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 129140 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-core-client/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 36662 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-core-server/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 5998 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-pherf/../src/main/config/checkstyle/checker.xml
 ruleset.
[INFO] There are 218 errors reported by Checkstyle 9.3 with 
/Users/nihjain/code/os/phoenix/phoenix-tracing-webapp/../src/main/config/checkstyle/checker.xml
 ruleset.
File: 67d47a612e745cf7f21a8522eb92209c4c43784f.txt
{code}


>  Update checkstyle checker.xml based on spotless rules
> ------------------------------------------------------
>
>                 Key: PHOENIX-7676
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7676
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: Nihal Jain
>            Assignee: Nihal Jain
>            Priority: Major
>
> {quote}For the changes where spotless checks are being applied, it is failing 
> checkstyle validation.
> Checkstyle validation failure :
> https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2238/2/artifact/yetus-general-check/output/results-checkstyle-phoenix-core-client.txt
> {quote}
> Ref: https://lists.apache.org/thread/9gbh5xs544h4q4w4xt64oy9osy8g8f81
> Confirmed same:
> Before, with commit#67d47a612e745cf7f21a8522eb92209c4c43784f:
> {code:java}
> phoenix % grep 'There [are|is]' 67d47a612e745cf7f21a8522eb92209c4c43784f.txt 
> [INFO] There are 13 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.6.0/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 13 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.5.4/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 13 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.5.0/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 13 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.4.1/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 33260 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-core-client/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 8727 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-core-server/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 1113 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-pherf/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 209 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-tracing-webapp/../src/main/config/checkstyle/checker.xml
>  ruleset.
> {code}
> After, with commit#f305a5c532d8e7693b7f14361d7b54a346a77ce6:
> {code:java}
> phoenix % grep 'There [are|is]' master.txt  
> [INFO] There are 197 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.6.0/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 196 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.5.4/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 193 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.5.0/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 189 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-hbase-compat-2.4.1/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 129140 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-core-client/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 36662 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-core-server/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 5998 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-pherf/../src/main/config/checkstyle/checker.xml
>  ruleset.
> [INFO] There are 218 errors reported by Checkstyle 9.3 with 
> /Users/nihjain/code/os/phoenix/phoenix-tracing-webapp/../src/main/config/checkstyle/checker.xml
>  ruleset.
> File: 67d47a612e745cf7f21a8522eb92209c4c43784f.txt
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to