Yeah, I did build upon that PR in the past and I'll do so again. I'm gone now for four weeks but plan on picking this up in September when I'm back.
Cheers, Lars On Wed, Aug 6, 2025 at 4:29 PM Istvan Toth <st...@cloudera.com.invalid> wrote: > > The problem with opentelemetry is that while configuring HTRace is > internal, a lot of the OpenTelemetry config is external. > At least two current features rely on HTrace features which are not present > in OpenTelemetry, and are also hard to implement. > - Writing traces to an HBase table > - Enabling / disabling tracing on a query by query basis > > I propose removing the first one, and disabling the second one (just log a > warning when the tracing would be enabled) > > The metrics logging to tables feature may also depend on HTRace, that may > also need to go. > > You can use my WIP patch as inspiration. > https://github.com/apache/phoenix/pull/1721 > > Basically just remove the parts where I tried to implement the advanced > features, and stick to replacing the spans and adding the minimum > dependencies. > We don't really care if the new tracing code even works at this point TBH. > (though my patch did work correctly) > (I'd also leave the sql grammar alone and just stub out the tracing > functionality) > > best regards > Istvan > > On Wed, Aug 6, 2025 at 3:52 PM Lars Francke <lars.fran...@gmail.com> wrote: > > > Hi everyone, > > > > this is about https://issues.apache.org/jira/browse/PHOENIX-5215. > > > > I did talk to Istvan about this last year and started some work on it > > but then dropped it because I wanted to wait for the spotless PR to > > merge. That took a bit longer than I expected but now that it's in > > (Thank you!) I want to pick it up again. > > > > I'd like to work on removing the current dependency on HTrace from Phoenix. > > As mentioned elsewhere it's broken anyway. > > > > I need to reacquaint myself with the code but if I remember there were > > a few options we could take: > > > > 1) Rip out HTrace entirely > > Would get rid of the dependency but also rip out the existing tracing > > hooks which would need to be re-added later. > > > > 2) Replace HTrace with the no-op dependency > > Would get rid of the CVE dependency but either inline a new one (even > > though no-op) or introduce an entirely new dependency. This, to me > > would only be a temporary solution but still an improvement. > > > > 3) Switch to OpenTelemetry > > Would get rid of HTrace (yay) and introduce useful new functionality > > but also the hardest of the three options. > > > > As with many of you my time is limited so I'd love to tackle this in > > smaller steps/increments. > > This mail is just meant to coordinate (I'll post a link to it on the > > issue as well) and to gather opinions so I don't duplicate anyone's > > work. > > > > If I don't hear any different I'd spend some timeboxed amount of work > > on option 3) but always with an eye towards option 2) instead. > > > > Any opinions/comments/questions? > > Is anyone else actively working on this? > > > > Cheers, > > Lars > > > > > -- > *István Tóth* | Sr. Staff Software Engineer > *Email*: st...@cloudera.com > cloudera.com <https://www.cloudera.com> > [image: Cloudera] <https://www.cloudera.com/> > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera > on LinkedIn] <https://www.linkedin.com/company/cloudera> > ------------------------------ > ------------------------------
