Thanks Istvan for taking care of this. On Wed, Oct 8, 2025, 06:13 Istvan Toth <[email protected]> wrote:
> HBase is restoring the coprocessors, everything is fine. > > > On Wed, Oct 8, 2025 at 11:45 AM Istvan Toth <[email protected]> wrote: > > > Thank you Tanuj. > > > > I have started the discussion at the HBase list : > > https://lists.apache.org/thread/31qr4wcyqc3oj40j768dkj7tj7jph6dx > > > > What paramters do you plane to use from the callback for the nre HA > > feature ? > > For the indexing we only use WALEdit.getCell() from the private class > > parameters. > > > > > > On Tue, Oct 7, 2025 at 6:23 PM Tanuj Khurana <[email protected]> > wrote: > > > >> Hi Istvan, > >> > >> Thanks for bringing this up. I came across this when working on the > >> PHOENIX-7562 feature where we need to override the "preWalRestore" hook > >> for > >> new indexes also. I would vote for option A or HBase provides some other > >> alternative. > >> > >> Thanks, > >> Tanuj > >> > >> On Mon, 6 Oct 2025 at 04:44, Istvan Toth <[email protected]> wrote: > >> > >> > Hi! > >> > > >> > I'm working on updating the HBase 3 support patch for Phoenix. > >> > > >> > So far, I have identified one protentially critical issue: > >> > The *preWalRestore* hook has been removed from the Observer interface. > >> > It is called from org.apache.phoenix.hbase.index.Indexer , and seems > to > >> be > >> > required for reliable operation of the old global secondary indexing > >> code. > >> > > >> > Now that one has been superceded by the new strongly consistent > indexing > >> > code, since 5.1, so this is not necessarily blocker, but we need to > >> decide > >> > how to handle this. Some options are: > >> > > >> > A.) Ask HBase to restore the hook in HBase 3, so that the old indexing > >> is > >> > still usable. > >> > B.) Document the issue, but otherwise do nothing (i.e accept the risk > of > >> > the index going out of sync) > >> > C.) Document the issue, and log a warning/error on HBase 3.0 > >> > D.) Document the issue, and make tables with old-style indexes > >> read-only on > >> > HBase 3.0 > >> > E.) Something else > >> > > >> > I personally prefer either A.) or D.) > >> > > >> > Please share your thoughts! > >> > > >> > Istvan > >> > > >> > > > > > > -- > > *István Tóth* | Sr. Staff Software Engineer > > *Email*: [email protected] > > cloudera.com <https://www.cloudera.com> > > [image: Cloudera] <https://www.cloudera.com/> > > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: > > Cloudera on LinkedIn] <https://www.linkedin.com/company/cloudera> > > ------------------------------ > > ------------------------------ > > > > > -- > *István Tóth* | Sr. Staff Software Engineer > *Email*: [email protected] > cloudera.com <https://www.cloudera.com> > [image: Cloudera] <https://www.cloudera.com/> > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera > on LinkedIn] <https://www.linkedin.com/company/cloudera> > ------------------------------ > ------------------------------ >
