[
https://issues.apache.org/jira/browse/PHOENIX-7881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated PHOENIX-7881:
-----------------------------------------
Description:
Now that we have infrastructure for parsing and validating EXPLAIN plan output
from PHOENIX-7879, we should use this instead of hardcoding exact text matches
in ~40 various IT and UT tests.
This is still test only changes. There are no changes made to the actual format
of EXPLAIN text output. We also are not expanding (or reducing) existing test
coverage. However now we are beginning to expand ExplainPlanAttributes to cover
everything, and tests begin to use a fluent API to assert over
ExplainPlanAttributes rather than exact matching of text strings.
Further test refactoring is likely down the road to fully rely on fluent
assertions using ExplainPlanAttributes, but that won't happen until the new
EXPLAIN logic is implemented and output grammar validation is built.
was:Now that we have infrastructure for parsing and validating EXPLAIN plan
output from PHOENIX-7879, we should use this instead of hardcoding exact text
matches in ~40 various IT and UT tests. This is still test only change. There
are no changes made to the actual format of EXPLAIN text output. However now we
are beginning to expand ExplainPlanAttributes to cover everything, and tests
begin to use a fluent API to assert over ExplainPlanAttributes rather than
exact matching of text strings. Further test refactoring is likely down the
road to fully rely on fluent assertions using ExplainPlanAttributes, but that
won't happen until the new EXPLAIN logic is implemented and output grammar
validation is built.
> Refactor QueryPlanTest and others to use explain compatibility test helpers
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-7881
> URL: https://issues.apache.org/jira/browse/PHOENIX-7881
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Andrew Kyle Purtell
> Assignee: Andrew Kyle Purtell
> Priority: Major
> Fix For: 5.4.0, 5.3.2
>
>
> Now that we have infrastructure for parsing and validating EXPLAIN plan
> output from PHOENIX-7879, we should use this instead of hardcoding exact text
> matches in ~40 various IT and UT tests.
> This is still test only changes. There are no changes made to the actual
> format of EXPLAIN text output. We also are not expanding (or reducing)
> existing test coverage. However now we are beginning to expand
> ExplainPlanAttributes to cover everything, and tests begin to use a fluent
> API to assert over ExplainPlanAttributes rather than exact matching of text
> strings.
> Further test refactoring is likely down the road to fully rely on fluent
> assertions using ExplainPlanAttributes, but that won't happen until the new
> EXPLAIN logic is implemented and output grammar validation is built.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
