[
https://issues.apache.org/jira/browse/PHOENIX-7881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell resolved PHOENIX-7881.
------------------------------------------
Resolution: Fixed
> Refactor UTs and ITs to assert on ExplainPlanAttributes
> -------------------------------------------------------
>
> Key: PHOENIX-7881
> URL: https://issues.apache.org/jira/browse/PHOENIX-7881
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Andrew Kyle Purtell
> Assignee: Andrew Kyle Purtell
> Priority: Major
> Fix For: PHOENIX-7876-feature
>
>
> Now that we have infrastructure for parsing and validating EXPLAIN plan
> output we use it instead of hardcoding exact text matches in ~70 various IT
> and UT tests.
> There are no changes made yet to the actual format of EXPLAIN text output.
> There are no changes, or should not be changes, to existing test coverage of
> anything. The tests after this PR test the same things as they used to test
> and assert on the same plan attributes as they used to implicitly assert
> using exact string matching.
> We expand ExplainPlanAttributes so tests can use a fluent assertion API
> (assertPlan) to assert over ExplainPlanAttributes rather than exact matching
> of text strings. After expanding ExplainPlanAttributes with additional
> details/fields we need, we also reorganize its attribute display order for
> better logical grouping. This only impacts future "EXPLAIN JSON"
> functionality that doesn't exist yet.
> Some exact matching of text remains so we don't lose coverage that used to
> exist in QueryPlanTest.
> Further test refactoring is likely down the road to fully rely on fluent
> assertions using ExplainPlanAttributes, but that won't happen until the new
> EXPLAIN logic is implemented and output grammar validation is built.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
