[
https://issues.apache.org/jira/browse/PHOENIX-7921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated PHOENIX-7921:
-----------------------------------------
Description: Remove unused bookkeeping from {{StatementContext}}. Drops
{{unionTags}}, {{addLiftedHavingNode()}}, {{isLiftedHavingNode()}} and the
backing {{liftedHavingNodes}} set (the HAVING-lift breadcrumb is still emitted
as a {{REWRITE HAVING PREDICATE AS WHERE}} line via {{appliedRewrites}}), and
{{addIndexExpressionSubstitution()}} / {{getIndexExpressionSubstitutions()}}
and the backing {{indexExpressionSubstitutions}} list. Removes the
corresponding fields, their entries in the copy constructor, the no-arg-init
constructor, and {{adoptRewriteState}}, plus the now-dead
{{breadcrumbContext.addIndexExpressionSubstitution()}} call in
{{IndexExpressionParseNodeRewriter}} and the {{addLiftedHavingNode}} loop in
{{HavingCompiler}}. No behavior change. EXPLAIN text and JSON output are
unchanged.
> Remove unread bookkeeping state from StatementContext
> -----------------------------------------------------
>
> Key: PHOENIX-7921
> URL: https://issues.apache.org/jira/browse/PHOENIX-7921
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Andrew Kyle Purtell
> Assignee: Andrew Kyle Purtell
> Priority: Major
> Fix For: PHOENIX-7876-feature
>
>
> Remove unused bookkeeping from {{StatementContext}}. Drops {{unionTags}},
> {{addLiftedHavingNode()}}, {{isLiftedHavingNode()}} and the backing
> {{liftedHavingNodes}} set (the HAVING-lift breadcrumb is still emitted as a
> {{REWRITE HAVING PREDICATE AS WHERE}} line via {{appliedRewrites}}), and
> {{addIndexExpressionSubstitution()}} / {{getIndexExpressionSubstitutions()}}
> and the backing {{indexExpressionSubstitutions}} list. Removes the
> corresponding fields, their entries in the copy constructor, the no-arg-init
> constructor, and {{adoptRewriteState}}, plus the now-dead
> {{breadcrumbContext.addIndexExpressionSubstitution()}} call in
> {{IndexExpressionParseNodeRewriter}} and the {{addLiftedHavingNode}} loop in
> {{HavingCompiler}}. No behavior change. EXPLAIN text and JSON output are
> unchanged.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
