[ 
https://issues.apache.org/jira/browse/PHOENIX-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Kyle Purtell updated PHOENIX-7924:
-----------------------------------------
    Description: 
Three fixes for bugs discovered while generating EXPLAIN/EXPLAIN 
VERBOSE/EXPLAIN JSON examples. 

{{LiteralExpression.toString()}} rendered typed-null literals as empty. Output 
now shows {{BSON_VALUE(..., null)}} instead of {{BSON_VALUE(..., )}}.

Leading whitespace was baked into functional index column names. Fixed by 
trimming at creation. Output now shows {{PROJECT "BSON_VALUE(...)"` instead of 
`PROJECT " BSON_VALUE(...)"}}.

{{REWRITE INDEX EXPRESSION <expr> AS <index col>}} breadcrumb was missing 
because it was always silently dropped. Drop the eager emission, store the col 
to expr substitution pairs on {{StatementContext}}, and emit one breadcrumb per 
actually fired substitution from {{QueryOptimizer.recordDecision}}.

  was:
Three fixes for bugs discovered while generating EXPLAIN/EXPLAIN 
VERBOSE/EXPLAIN JSON examples. 

`LiteralExpression.toString()` rendered typed-null literals as empty. Output 
now shows `BSON_VALUE(..., null)` instead of `BSON_VALUE(..., )`.

Leading whitespace was baked into functional index column names. Fixed by 
trimming at creation. Output now shows `PROJECT "BSON_VALUE(...)"` instead of 
`PROJECT " BSON_VALUE(...)"`.

`REWRITE INDEX EXPRESSION <expr> AS <index col>` breadcrumb was missing because 
it was always silently dropped. Drop the eager emission, store the col to expr 
substitution pairs on `StatementContext`, and emit one breadcrumb per actually 
fired substitution from `QueryOptimizer.recordDecision`.


> EXPLAIN improvement bug fixes
> -----------------------------
>
>                 Key: PHOENIX-7924
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-7924
>             Project: Phoenix
>          Issue Type: Sub-task
>    Affects Versions: PHOENIX-7876-feature
>            Reporter: Andrew Kyle Purtell
>            Assignee: Andrew Kyle Purtell
>            Priority: Major
>
> Three fixes for bugs discovered while generating EXPLAIN/EXPLAIN 
> VERBOSE/EXPLAIN JSON examples. 
> {{LiteralExpression.toString()}} rendered typed-null literals as empty. 
> Output now shows {{BSON_VALUE(..., null)}} instead of {{BSON_VALUE(..., )}}.
> Leading whitespace was baked into functional index column names. Fixed by 
> trimming at creation. Output now shows {{PROJECT "BSON_VALUE(...)"` instead 
> of `PROJECT " BSON_VALUE(...)"}}.
> {{REWRITE INDEX EXPRESSION <expr> AS <index col>}} breadcrumb was missing 
> because it was always silently dropped. Drop the eager emission, store the 
> col to expr substitution pairs on {{StatementContext}}, and emit one 
> breadcrumb per actually fired substitution from 
> {{QueryOptimizer.recordDecision}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to