I'm definitely fine with targeting 5.4. I mean, not putting it in the current release line of 5.3. For sore. But that's a minor release. I suppose Phoenix minor releases are more like major releases already. :-/ If someone writes in and objects because they are actively parsing EXPLAIN text, that would be a good reason to reconsider. We can wait a while. Otherwise this change also introduces a myriad of unit tests that actually check and confirm EXPLAIN output and attribute stability that has never been in place before. We are much better positioned to ensure that stability going forward, which is another reason IMHO to do it now. For your consideration.
On Tue, Jun 23, 2026 at 10:48 AM Daniel Wong <[email protected]> wrote: > If I recall correctly a long time ago there were some people parsing the > explain plan. As long as its targeting a major release should be okay I > forget the exact standards. > > On Tue, Jun 23, 2026 at 10:29 AM Andrew Purtell <[email protected]> > wrote: > > > Bump. > > > > Any concerns? > > > > If not I will take this as lazy consensus and merge the branch. > > > > On Thu, Jun 18, 2026 at 9:43 PM Andrew Purtell <[email protected]> > > wrote: > > > > > I would like to raise for your consideration merging the EXPLAIN > > > improvement work that was developed in the PHOENIX-7876-feature[1][2] > > > branch. The tl;dr on this work is that it updates EXPLAIN to cover all > > > Phoenix capabilities and significantly improves its coverage of > optimizer > > > decision making and the fidelity of the resulting execution plan > > > representation, and introduces 'EXPLAIN FORMAT JSON' to enable better > > > integration with automated monitoring and agentic systems. > > > > > > For your consideration and review, there is a design doc [3], a branch > > > reviewer's guide [4], a catalog of ~60 worked examples [5], and > > attestation > > > of test results [6]. > > > > > > Although I have tested the complete suite locally, I am unsure how to > > test > > > a feature branch on ASF Phoenix GitHub and would appreciate your advice > > and > > > pointers in this regard. > > > > > > [1] https://github.com/apache/phoenix/tree/PHOENIX-7876-feature > > > [2] https://github.com/apache/phoenix/commits/PHOENIX-7876-feature/ > > > [3] > > > > > > https://docs.google.com/document/d/10H_MNWGQL7ZzsPmIVBMz7T1jJroez8AYpvwouKcBVQo/edit?tab=t.0 > > > [4] > > > > > > https://issues.apache.org/jira/secure/attachment/13082781/PHOENIX_EXPLAIN_REVIEWER_GUIDE.md > > > [5] > > > > > > https://issues.apache.org/jira/secure/attachment/13082782/PHOENIX_EXPLAIN_EXAMPLES.md > > > [6] > > > > > > https://issues.apache.org/jira/secure/attachment/13082865/PHOENIX_7876_MERGE_TEST_REPORT.md > > > > > > > > > -- > > > Best regards, > > > Andrew > > > > > >
