PDavid commented on code in PR #37:
URL: https://github.com/apache/phoenix-site/pull/37#discussion_r3711651369
##########
build.sh:
##########
Review Comment:
Super-minor / nit:
If Node is installed just with different version than the required, then the
script will fail with:
```
$ ./build.sh
Generate Phoenix Website
CHECKING PREREQUISITES
===========================
node v22.22.3, npm 10.9.8 -- OK
INSTALLING DEPENDENCIES (clean install)
===========================
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE package: undefined,
npm warn EBADENGINE required: { node: '>=24.0.0' },
npm warn EBADENGINE current: { node: 'v22.22.3', npm: '10.9.8' }
npm warn EBADENGINE }
npm error process terminated
npm error signal SIGINT
npm error A complete log of this run can be found in:
xxx/.npm/_logs/2026-08-04T10_20_00_833Z-debug-0.log
$
$ node -v
v22.22.3
$
```
##########
output/llms-full.txt:
##########
@@ -5244,7 +5244,7 @@ ALTER TABLE my_table SET GUIDE_POSTS_WIDTH = 10000000;
* A denser guidepost setting improves sampling accuracy, but may reduce
performance. A comparison is shown below.
-<img alt="Table sampling performance" src={__img0} placeholder="blur" />
+<img alt="Table sampling performance" src={__img0} />
Review Comment:
Maybe stupid question but is it useful to have img HTML tags here in this
text file? Will this be useful for LLM-s? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
