As a GUI tool for reviewing code line by line, Reviewboard is fine in place
of Gerrit in my opinion. Gerrit is interesting if you want to also set up a
workflow where the review tool itself gates commits into the master branch.
However, we have a separate process in the Hadoop parts of ASF land
("HadoopQA") which can stand in for that role, as Jesse mentioned.On Wed, Jan 29, 2014 at 8:42 AM, James Taylor <jamestay...@apache.org>wrote: > Gerrit sounds interesting. Sounds like infra dismissed it though. Will ask > about this on the general list too. > Thanks, > James > > On Wednesday, January 29, 2014, Nick Dimiduk <ndimi...@gmail.com> wrote: > > > Hi James, > > > > I don't have any good recommendations for preserving your Github-based > > community on the Apache infrastructure. Maybe our friends on other Apache > > projects that have made the transition, such as Storm or Mesos, have > > experience to share? > > > > Outside of Github, I've been very happy using Gerrit [0] for git-based > code > > review. It supports a workflow such that commits to the "central" > > repository can only be performed via its web interface and only after the > > necessary +1 has been received. This also lets you enforce different > commit > > policies, including a fast-forward-only workflow (ie, a SVN-like linear > > commit history). I'm afraid I've never configured a public git > repository, > > nor Gerrit, so my advice ends there. > > > > There's this old ticket [1] which hasn't received much attention. > > > > Let me know if I can provide more concrete assistance. > > > > -n > > > > [0]: https://code.google.com/p/gerrit/ > > [1]: https://issues.apache.org/jira/browse/INFRA-2205 > > > > > > On Tue, Jan 28, 2014 at 11:09 PM, Devaraj Das <d...@hortonworks.com > <javascript:;>> > > wrote: > > > > > And there is reviewboard which is pretty widely used in HBase for the > > > code review (and that works off git repo too).. > > > > > > On Tue, Jan 28, 2014 at 10:54 PM, Devaraj Das <d...@hortonworks.com > <javascript:;> > > > > > > wrote: > > > > Hey James, couldn't we use the jira comments as a way to > > > > discuss/feedback, even though we use git repo? > > > > > > > > On Tue, Jan 28, 2014 at 10:47 PM, James Taylor < > jamestay...@apache.org<javascript:;> > > > > > > wrote: > > > >> I know you HBase guys use svn as your source of truth, but Phoenix > is > > > using > > > >> git. With our old git repo which was hosted on github, we'd > typically > > do > > > >> work locally and then send a pull request to the source-of-truth > > github > > > >> repo. That way others could comment on the pending commit before it > > was > > > >> pulled in. Pulling it in could be done with a single click by > someone > > > with > > > >> write privileges. > > > >> > > > >> Now, though, our source-of-truth is *not* on github, but on a git > repo > > > >> hosted by Apache. It's only mirrored to github in a read-only > manner. > > > Plus, > > > >> it may be lagging behind the source-of-truth repo. > > > >> > > > >> What's the best, recommended methodology and ui to use for getting > > > feedback > > > >> pre-commit? > > > >> > > > >> Thanks, > > > >> James > > > > > > -- > > > CONFIDENTIALITY NOTICE > > > NOTICE: This message is intended for the use of the individual or > entity > > to > > > which it is addressed and may contain information that is confidential, > > > privileged and exempt from disclosure under applicable law. If the > reader > > > of this message is not the intended recipient, you are hereby notified > > that > > > any printing, copying, dissemination, distribution, disclosure or > > > forwarding of this communication is strictly prohibited. If you have > > > received this communication in error, please contact the sender > > immediately > > > and delete it from your system. Thank You. > > > > > > -- Best regards, - Andy Problems worthy of attack prove their worth by hitting back. - Piet Hein (via Tom White)
