GitHub user ramkrish86 opened a pull request:
https://github.com/apache/incubator-phoenix/pull/8
Phoenix 37
First cut pull request. Still not changed the format of serialization of
variable length array in ArrayConstructorExpression.
Moved the HEader information of the array's serailzation to the end. (When
you say comparsion would be easier what way you mean?)
Made some small changes in the size calc.. Before there was one byte always
additonal in the serialization. Because now we have moved the header details to
the end i have removed that one byte (it was added by mistake).
Not the final one, just for your reviews. Will work on top of your
comments.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ramkrish86/incubator-phoenix Phoenix-37
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-phoenix/pull/8.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8
----
commit 702ffb87eba01b6dd5bdde0ad3eba6b18a02daca
Author: Ramkrishna <[email protected]>
Date: 2014-02-18T19:29:28Z
Phoenix-37
commit a3872e000889b44d42f7a5852afc7b29e242cd8d
Author: Ramkrishna <[email protected]>
Date: 2014-02-18T19:31:54Z
Revert "Phoenix-37"
This reverts commit 702ffb87eba01b6dd5bdde0ad3eba6b18a02daca.
commit aef427df4136c930e4bb71ed1b9dd3e1d577d995
Author: Ramkrishna <[email protected]>
Date: 2014-02-18T19:32:38Z
Merge remote-tracking branch 'origin/master'
commit 5671b2fcb954985825e828ca01c5a40c9398461d
Author: Ramkrishna <[email protected]>
Date: 2014-02-18T19:33:09Z
Phoenix-37
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
[email protected] or file a JIRA ticket with INFRA.
---
