Github user JamesRTaylor commented on the pull request:
https://github.com/apache/incubator-phoenix/pull/8#issuecomment-35469351
It's not the minor perf gain of comparing the header information that I'm
talking about. It's the fact that it makes comparing the byte arrays directly
impossible. For example, consider comparing two arrays:
7, 3
6, 2, 1
The first one should be bigger, since 7 is bigger than 6. However, if the
header info is up front it would sort the other way, since the first byte would
store the array length, which would compare 2 against 3 and conclude that the
second array is bigger. By putting the header info at the end you prevent this
mistake.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
[email protected] or file a JIRA ticket with INFRA.
---
