Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r9903866
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java
---
@@ -62,27 +67,62 @@ public void reset() {
position = 0;
Arrays.fill(elements, null);
}
-
+
@Override
public boolean evaluate(Tuple tuple, ImmutableBytesWritable ptr) {
- for (int i = position >= 0 ? position : 0; i < elements.length;
i++) {
- Expression child = children.get(i);
- if (!child.evaluate(tuple, ptr)) {
- if (tuple != null && !tuple.isImmutable()) {
- if (position >= 0) position = i;
- return false;
+ try {
+ int offset = 0;
+ // track the elementlength for variable array
+ int elementLength = 0;
+ for (int i = position >= 0 ? position : 0; i <
elements.length; i++) {
+ Expression child = children.get(i);
+ if (!child.evaluate(tuple, ptr)) {
+ if (tuple != null && !tuple.isImmutable()) {
+ if (position >= 0) position = i;
+ return false;
+ }
+ } else {
+ // track the offset position here from the size of the
byteStream
+ if (!baseType.isFixedWidth() ||
baseType.isCoercibleTo(PDataType.VARCHAR)) {
+ Bytes.putInt(offsetArr, offset,
(byteStream.size()));
+ offset += Bytes.SIZEOF_INT;
+ elementLength += ptr.getLength();
+ }
+ if (!child.isStateless()) {
+ oStream.write(ptr.get(), ptr.getOffset(),
ptr.getLength());
+ } else {
+ oStream.write(ptr.get());
+ }
}
- } else {
- elements[i] = baseType.toObject(ptr, child.getDataType(),
child.getSortOrder());
+ }
+ if (position >= 0) position = elements.length;
+ if (!baseType.isFixedWidth() ||
baseType.isCoercibleTo(PDataType.VARCHAR)) {
+ oStream.writeByte(0);
--- End diff --
But one query, when we seriliaze as a byte buffer, how to know the size
required for writing this consecutive null value? It may be located in between
also and many such occurences could occur, like
a, b, null, null, c, d, null, d, null, e, null, null,f like this.
Am not saying this cannot be done, the thing is we may have to iterate thro
the Array and find out such occurences and calculate the bytes needed to store
them apart from the double null byte at the end, which will happen in any case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
[email protected] or file a JIRA ticket with INFRA.
---
