Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/incubator-phoenix/pull/8#discussion_r9974799
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
    @@ -17,21 +17,24 @@
      */
     package org.apache.phoenix.schema;
     
    +import java.io.DataOutputStream;
    +import java.io.IOException;
     import java.nio.ByteBuffer;
     import java.sql.Types;
     
     import org.apache.hadoop.hbase.io.ImmutableBytesWritable;
     import org.apache.hadoop.hbase.util.Bytes;
    -
    +import org.apache.hadoop.hbase.util.Pair;
    +import org.apache.phoenix.query.QueryConstants;
     import org.apache.phoenix.util.ByteUtil;
    +import org.apache.phoenix.util.TrustedByteArrayOutputStream;
     
     /**
      * The datatype for PColummns that are Arrays
      */
     public class PArrayDataType {
    --- End diff --
    
    Please make sure to update your javadoc for this, as it's documenting the 
old format (just copy/paste from your new comments that explain it here).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
[email protected] or file a JIRA ticket with INFRA.
---

Reply via email to