[ https://issues.apache.org/jira/browse/PHOENIX-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911308#comment-13911308 ]
James Taylor commented on PHOENIX-53: ------------------------------------- +1. Thanks for the patch, [~jviolettedsiq]. [~jesse_yates] - would you mind reviewing the pom changes? Will adding the commons-csv source jar cause any complications? > CSV loader fails on empty line > ------------------------------ > > Key: PHOENIX-53 > URL: https://issues.apache.org/jira/browse/PHOENIX-53 > Project: Phoenix > Issue Type: Bug > Affects Versions: 2.2.3 > Reporter: James Violette > Labels: patch > Fix For: 2.2.3 > > Attachments: commons-csv-1.0-SNAPSHOT.jar, > incubator-phoenix-commons-csv-rev1.patch, incubator-phoenix-csv-commons.patch > > > in org.apache.phoenix.util.CSVLoader, the upsert fails if it encounters an > empty line. This occurs if all lines end with the new line character and the > reader returns an empty line at the end. > A fix is to add a guard while reading the next line. > public void upsert(CSVReader reader) throws Exception { > ... > while ((nextLine = reader.readNext()) != null) { > if (nextLine.length==0) { > continue; > } -- This message was sent by Atlassian JIRA (v6.1.5#6160)