[ 
https://issues.apache.org/jira/browse/PHOENIX-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921787#comment-13921787
 ] 

Hudson commented on PHOENIX-32:
-------------------------------

FAILURE: Integrated in Apache Phoenix - Branch:4.0 #35 (See 
[https://builds.apache.org/job/Phoenix-4.0/35/])
Fix NPE introduced by my previous fix for Phoenix-32 - SortOrder was being 
passed in as null instead of ASC. (stoens: rev 
fe18e96ae429cc0e4291075177d0e0c5f5e9a5b1)
* phoenix-core/src/main/java/org/apache/phoenix/schema/SaltingUtil.java


> Replace generic ColumnModifier with specific SortOrder
> ------------------------------------------------------
>
>                 Key: PHOENIX-32
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-32
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 2.2.3
>            Reporter: Simon Toens
>            Assignee: Simon Toens
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: Phoenix-32.patch
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> We added ColumnModifier thinking that it may be a generic concept but it 
> turns out that it is only used to describe a row key column that stores its 
> values in descending order.  In order to make the purpose of this enum more 
> apparent and improve code readability, rename it to "SortOrder".  Also make 
> sure it is either ASC or DESC and never null



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to