[ https://issues.apache.org/jira/browse/PHOENIX-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925153#comment-13925153 ]
Hudson commented on PHOENIX-116: -------------------------------- SUCCESS: Integrated in Apache Phoenix - Branch:master #120 (See [https://builds.apache.org/job/Phoenix/120/]) PHOENIX-116 Phoenix array integer types overlap with existing java.sql.Types (Gabriel Reid) (jamestaylor: rev 0da3a52b9d4a4525837a834b2ebc6393f731f4d1) * phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayLengthFunction.java * phoenix-core/src/main/java/org/apache/phoenix/schema/PDataType.java * phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java * phoenix-core/src/main/java/org/apache/phoenix/expression/ArrayConstructorExpression.java * phoenix-core/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java * phoenix-core/src/main/java/org/apache/phoenix/expression/function/ArrayIndexFunction.java > Phoenix array integer types overlap with existing java.sql.Types > ---------------------------------------------------------------- > > Key: PHOENIX-116 > URL: https://issues.apache.org/jira/browse/PHOENIX-116 > Project: Phoenix > Issue Type: Bug > Reporter: Gabriel Reid > Assignee: ramkrishna.s.vasudevan > Fix For: 3.0.0 > > Attachments: PHOENIX-116.patch, PHOENIX-116_1.patch > > > The type value returned for Phoenix typed arrays are currently created by > taking the sum of java.sql.Types.ARRAY and the sql type of the element type. > However, this causes some collisions with existing java.sql.Types values. > For example, the SQL type value for BINARY_ARRAY is the value of Types.ARRAY > + Types.BINARY, which is 2003 + (-2), or 2001. 2001 is an existing constant > for java.sql.Types.DISTINCT. > There is also a collision with java.sql.Types.BLOB and > PDataTypes.CHAR_ARRAY.getSqlType(). > Next to the fact that these collisions occur, there's probably not much > reason to base the SQL types for typed arrays on the java.sql.Types.ARRAY > constant, as I assume that external tooling won't be aware of this convention > anyhow. -- This message was sent by Atlassian JIRA (v6.2#6252)