[ 
https://issues.apache.org/jira/browse/PHOENIX-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940060#comment-13940060
 ] 

James Taylor commented on PHOENIX-869:
--------------------------------------

The intention with the Calendar version of getDate/Time/Timestamp was to 
convert the time (which is stored in GMT) to the time in a potentially 
different time zone depending on the Calendar passed through. Is that not the 
case?

Unless this is broken, my preference would be to do any necessary modification 
once we look at the bigger time issue you filed for 
https://issues.apache.org/jira/browse/PHOENIX-868. Can't the consumer/user of 
the JDBC driver just use the non Calendar ResultSet calls?

> Remove unused Calendar conversions in ResultSet and PreparedStatement
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-869
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-869
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Gabriel Reid
>            Priority: Minor
>         Attachments: PHOENIX-869.patch
>
>
> The PhoenixResultSet and PhoenixPreparedStatement methods that accept a 
> Calendar object currently appear to perform what is effectively a no-op with 
> the Calendar. 
> The time and date values are currently stored as absolute timestamps (and 
> lacking any timezone information). There is a larger underlying problem with 
> date and time handling in Phoenix, which is outlined in PHOENIX-868 -- 
> however, there's no reason to keep performing the extra calendar operations 
> that have no effect.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to