Github user prashantkommireddi commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/22#discussion_r10812932
--- Diff:
phoenix-pig/src/main/java/org/apache/phoenix/pig/PhoenixPigConfiguration.java
---
@@ -121,6 +129,20 @@ public void setup(Connection conn) throws SQLException
{
String upsertStmt =
QueryUtil.constructGenericUpsertStatement(getTableName(),
columnMetadataList.size());
LOG.info("Phoenix Upsert Statement: " + upsertStmt);
conf.set(UPSERT_STATEMENT, upsertStmt);
+
+ if(this.conf.get(SELECT_STATEMENT) == null) {
+ final String selectStatement =
QueryUtil.constructSelectStatement(columnMetadataList, getTableName());
--- End diff --
The docs currently for this method are specific to UPSERT. Should the
upsert/select statement formation be broken into separate methods?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
