[
https://issues.apache.org/jira/browse/PHOENIX-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeffrey Zhong updated PHOENIX-881:
----------------------------------
Attachment: phoenix-881.patch
The patch is low risk where most changes are replacing the constant
PHOENIX_JDBC_URL with getUrl() call in testing code.
Only one non-test code change is in MetaDataEndpointImpl.java as following in
order to avoid the following scan. If the scan doesn't return empty result,
we'll get NPE anyway because table=null.
{noformat}
- if (table == null && buildDeletedTable(key, cacheKey, region,
clientTimeStamp) != null) {
- return new MetaDataMutationResult(MutationCode.NEWER_TABLE_FOUND,
+ if (table == null) {
+ if(buildDeletedTable(key, cacheKey, region, clientTimeStamp) !=
null) {
+ return new
MetaDataMutationResult(MutationCode.NEWER_TABLE_FOUND,
EnvironmentEdgeManager.currentTimeMillis(), null);
+ } else {
+ return new MetaDataMutationResult(MutationCode.TABLE_NOT_FOUND,
+ EnvironmentEdgeManager.currentTimeMillis(), null);
+ }
}
{noformat}
The other changes are in BaseConnectedQueryIT.java where we don't compose JDBC
URL because some times zookeeper quorum value itself could contain ":" which
will fail parsing code later.
In addition, in BaseConnectedQueryIT#deletePriorTables function, explicitly
clear metadata cache.
> end2end test fails to run against a live cluster using end2endtest.py
> ---------------------------------------------------------------------
>
> Key: PHOENIX-881
> URL: https://issues.apache.org/jira/browse/PHOENIX-881
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 3.0.0, 4.0.0
> Reporter: Jeffrey Zhong
> Assignee: Jeffrey Zhong
> Attachments: phoenix-881.patch
>
>
> In most IT tests, we're using constant PHOENIX_JDBC_URL instead of
> BaseConnectedQueryIT#getUrl() which will return correct url depending where
> the test is running against.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
