Github user mravi commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/22#discussion_r10860041
--- Diff:
phoenix-pig/src/main/java/org/apache/phoenix/pig/hadoop/PhoenixInputFormat.java
---
@@ -0,0 +1,118 @@
+/*
+ * Copyright 2010 The Apache Software Foundation
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ *distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you maynot use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicablelaw or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.pig.hadoop;
+
+import java.io.IOException;
+import java.sql.Connection;
+import java.sql.SQLException;
+import java.sql.Statement;
+import java.util.List;
+
+import javax.security.auth.login.Configuration;
+
+import org.apache.phoenix.pig.PhoenixPigConfiguration;
+
+public final class PhoenixInputFormat extends InputFormat<NullWritable,
PhoenixRecord> {
+
+ private static final Log LOG =
LogFactory.getLog(PhoenixInputFormat.class);
+ private PhoenixPigConfiguration config;
+
+ /**
+ * instantiated by framework
+ */
+ public PhoenixInputFormat() {
+ }
+
+ @Override
+ public RecordReader<NullWritable, PhoenixRecord>
createRecordReader(InputSplit split, TaskAttemptContext context)
+ throws IOException, InterruptedException {
+
+ final PhoenixPigConfiguration pigConfiguration =
getPhoenixConfiguration(context);
+ return new PhoenixRecordReader(pigConfiguration);
+ }
+
+
+
+ @Override
+ public List<InputSplit> getSplits(JobContext context) throws
IOException, InterruptedException {
+
+ List<InputSplit> splits = null;
+ try{
+ Configuration configuration = context.getConfiguration();
+ this.config = new PhoenixPigConfiguration(configuration);
+ final Connection connection = config.getConnection(true);
+ final String selectStatement = config.getSelectStatement();
+ Preconditions.checkNotNull(selectStatement);
+
+ final Statement statement = connection.createStatement();
+ final PhoenixStatement pstmt =
statement.unwrap(PhoenixStatement.class);
+ final QueryPlan queryPlan =
pstmt.compileQuery(selectStatement);
+ @SuppressWarnings("unused")
+ final ResultIterator iterator = queryPlan.iterator();
+ final List<KeyRange> allSplits = queryPlan.getSplits();
+ splits = getValidSplits(queryPlan,allSplits);
+ } catch(SQLException sqlE) {
+ LOG.error(String.format(" Error [%s] in getSplits of
PhoenixInputFormat ", sqlE.getMessage()));
+ Throwables.propagate(sqlE);
+ }
+ return splits;
+ }
+
+ private List<InputSplit> getValidSplits(final QueryPlan qplan, final
List<KeyRange> splits) throws IOException {
--- End diff --
True, I realized the code duplication and felt the need to have the code be
restricted within QueryPlan and have started working on the change. Will submit
that in the next patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
