Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/32#discussion_r12034129
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/HashJoinRegionScanner.java
---
@@ -106,7 +113,7 @@ private void processResults(List<Cell> result, boolean
hasLimit) throws IOExcept
return;
}
- if (hasLimit)
+ if (hasBatchLimit)
throw new UnsupportedOperationException("Cannot support join
operations in scans with limit");
--- End diff --
This is actually to indicate if it is called from the "next" interface with
"limit" parameter, like "next(List<Cell> result, int limit)", and has nothing
to do with the SQL LIMIT clause. And that's why I renamed it "hasBatchLimit".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
