[ 
https://issues.apache.org/jira/browse/PIG-1686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923643#action_12923643
 ] 

Ashutosh Chauhan commented on PIG-1686:
---------------------------------------

Currently in load func:
{code}
    @SuppressWarnings("unchecked")
    public abstract InputFormat getInputFormat() throws IOException;
    @SuppressWarnings("unchecked")
    public abstract void prepareToRead(RecordReader reader, PigSplit split) 
throws IOException;
{code}

should be: 
{code}
 public abstract InputFormat<? extends WritableComparable<?>, ? extends 
Writable> getInputFormat() throws IOException;
public abstract void prepareToRead(RecordReader<? extends 
WritableComparable<?>, ? extends Writable> reader, PigSplit split) throws 
IOException;
{code}

Similarily in storefunc and storefuncInterface.  I think this is  
backward-compatible.


> Genericize return types of methods defined in loadfunc / storefunc
> ------------------------------------------------------------------
>
>                 Key: PIG-1686
>                 URL: https://issues.apache.org/jira/browse/PIG-1686
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Ashutosh Chauhan
>
> Couple of methods defined in loadfunc and storefuncs should have genericized 
> return types. Without that, type safety goes for a toss.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to