[ 
https://issues.apache.org/jira/browse/PIG-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan updated PIG-1696:
----------------------------------

    Fix Version/s: 0.9.0
         Assignee: Ashutosh Chauhan
           Status: Patch Available  (was: Open)

This requires no new tests as it changes only  the internal implementation. 
Existing testcases covers the functionality provided. They are in 
TestDataByteArray.java Additionally, PigStorage heavily uses this, so all the 
tests using PigStorage provides additional coverage. I ran all the unit tests. 
All of them passes. This is ready for review. 

> Performance: Use System.arraycopy() instead of manually copying the bytes 
> while reading the data
> ------------------------------------------------------------------------------------------------
>
>                 Key: PIG-1696
>                 URL: https://issues.apache.org/jira/browse/PIG-1696
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Ashutosh Chauhan
>            Assignee: Ashutosh Chauhan
>            Priority: Minor
>             Fix For: 0.9.0
>
>         Attachments: dba_syscp.patch
>
>
> System.arraycopy() is said to be faster as compared to iterating over bytes 
> and copying them over as it is implemented natively in JVM. Since every 
> single byte read through PigStorage() will go through this code-path, this 
> will have a performance impact.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to