[
https://issues.apache.org/jira/browse/PIG-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12966725#action_12966725
]
Thejas M Nair commented on PIG-1618:
------------------------------------
Review comments on NewParser-6.patch -
- AstValidator.g - HashSet would be a better choice than HashMap for keeping
track of unique schema aliases
- ParserTestingUtils.java - insertDefaultDataType and checkSchemaAlias do the
same thing. We can consolidate them together into getValidatedAST().
- TestAstValidator.java- insertDefaultDataType is also not used currently, i
think it will be good to call the consolidated function (getValidatedAST() ? )
from testDefaultDataTypeInsertion
- TestAstValidator.java - can we also check for line and column number in the
error message ?
> Switch to new parser generator technology
> -----------------------------------------
>
> Key: PIG-1618
> URL: https://issues.apache.org/jira/browse/PIG-1618
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.8.0
> Reporter: Alan Gates
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: antlr-3.2.jar, javadoc.patch, NewParser-1.patch,
> NewParser-2.patch, NewParser-3.patch, NewParser-3.patch, NewParser-4.patch,
> NewParser-5.patch, NewParser-6.patch
>
>
> There are many bugs in Pig related to the parser, particularly to bad error
> messages. After review of Java CC we feel these will be difficult to address
> using that tool. Also, the .jjt files used by JavaCC are hard to understand
> and maintain.
> ANTLR is being reviewed as the most likely choice to move to, but other
> parsers will be reviewed as well.
> This JIRA will act as an umbrella issue for other parser issues.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
