-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/152/
-----------------------------------------------------------
(Updated 2010-12-08 16:29:48.542866)
Review request for pig and Richard Ding.
Summary
-------
Pig does not handle deep cast from bag -> bag, tuple -> tuple. Eg, the
following script does not produce desired result:
a = load '1.txt' as (a0:bag{t:tuple(i0:double)});
b = foreach a generate (bag{tuple(int)})a0;
dump b;
The result tuple still contain int inside tuple of bag.
This addresses bug PIG-1758.
https://issues.apache.org/jira/browse/PIG-1758
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POCast.java
1042930
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPOCast.java
1042930
Diff: https://reviews.apache.org/r/152/diff
Testing
-------
test-patch:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] -1 release audit. The applied patch generated 451 release
audit warnings (more than the trunk's current 450 warnings).
release audit is due to jdiff, not related to code.
unit-test:
all pass
end-to-end test:
all pass
Thanks,
Daniel
