[
https://issues.apache.org/jira/browse/PIG-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972165#action_12972165
]
Alan Gates commented on PIG-1755:
---------------------------------
+1 on the changes. When I went to apply the patch, most of it failed to apply.
If you can regenerate I can run a number of end-to-end tests on it that would
be good to do before we check it in.
> Clean up duplicated code in Physical Operators
> ----------------------------------------------
>
> Key: PIG-1755
> URL: https://issues.apache.org/jira/browse/PIG-1755
> Project: Pig
> Issue Type: Improvement
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Fix For: 0.9.0
>
> Attachments: PIG-1755.2.patch, PIG-1755.patch
>
>
> A lot of the getNext() implementations in PhysicalOperators is copy-pasted,
> with only the method signatures and casts changing.
> Shorter code leads to less bugs and is easier to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.