----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/276/#review128 -----------------------------------------------------------
Ship it! - Richard On 2011-01-12 13:59:12, Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/276/ > ----------------------------------------------------------- > > (Updated 2011-01-12 13:59:12) > > > Review request for pig and Richard Ding. > > > Summary > ------- > > Query which fails: > > a = load ':INPATH:/singlefile/studenttab10k' as (name:chararray, age:int, > gpa:double); > b = group a by name; > c = foreach b generate group, SUM(a.age*a.gpa); > store c into ':OUTPATH:';\, > > Should fail in frontend and give meaningful error message. > > > This addresses bug PIG-313. > https://issues.apache.org/jira/browse/PIG-313 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestEvalPipeline2.java > 1058308 > > Diff: https://reviews.apache.org/r/276/diff > > > Testing > ------- > > Test-patch: > [exec] +1 overall. > [exec] > [exec] +1 @author. The patch does not contain any @author tags. > [exec] > [exec] +1 tests included. The patch appears to include 3 new or > modified tests. > [exec] > [exec] +1 javadoc. The javadoc tool did not generate any warning > messages. > [exec] > [exec] +1 javac. The applied patch does not increase the total > number of javac compiler warnings. > [exec] > [exec] +1 findbugs. The patch does not introduce any new Findbugs > warnings. > [exec] > [exec] +1 release audit. The applied patch does not increase the > total number of release audit warnings. > > Unit-test: > This patch does not change any Pig code. Only adding one test case. So I > didn't run unit test. > > > Thanks, > > Daniel > >
