-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/387/
-----------------------------------------------------------
Review request for pig and thejas.
Summary
-------
We should consider using logic for merging inner schema in case of the two
different types of union.
In case of 'default union', it merges the two inner schema of bags/tuples by
position if the number of fields are same and the corresponding types are
compatible.
In case of 'union onschema', it considers tuple/bag with different innerschema
to be incompatible types.
This addresses bug PIG-1536.
https://issues.apache.org/jira/browse/PIG-1536
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/data/DataType.java
1066263
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LOGenerate.java
1066263
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LOLoad.java
1066263
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LOUnion.java
1066263
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LogicalSchema.java
1066263
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/parser/TestUnionOnSchemaSetter.java
1066263
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestEvalPipeline2.java
1066263
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestSchema.java
1066263
Diff: https://reviews.apache.org/r/387/diff
Testing
-------
Test-patch:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 9 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] -1 release audit. The applied patch generated 514 release
audit warnings (more than the trunk's current 512 warnings).
No new file added. Ignore "release audit".
Unit-test:
all pass
End-to-end test:
all pass
Thanks,
Daniel
