> On 2011-02-07 15:25:52, Julien Le Dem wrote: > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMacroExpansion.java, > > line 3 > > <https://reviews.apache.org/r/400/diff/1/?file=10791#file10791line3> > > > > Can a Macro call another Macro ? > > This would be useful. > > > > > > Richard Ding wrote: > Macro recursion is not supported.
Let me clarify: Macro inlining is not a complete replacement for function calls, as it does not support recursive calls. However, macros will be allowed to inline other macros (but forward declarations will not be supported). This feature is not in the current patch and will be added in the next patch. - Richard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/400/#review189 ----------------------------------------------------------- On 2011-02-07 10:13:39, Richard Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/400/ > ----------------------------------------------------------- > > (Updated 2011-02-07 10:13:39) > > > Review request for pig and Julien Le Dem. > > > Summary > ------- > > As production Pig scripts grow longer and longer, Pig Latin has a need to > integrate standard programming techniques of separation and code sharing > offered by functions and modules. A detailed proposal of adding macro > expansion to Pig Latin is posted here: > http://wiki.apache.org/pig/TuringCompletePig > > > This addresses bug PIG-1793. > https://issues.apache.org/jira/browse/PIG-1793 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/pig/trunk/build.xml 1067233 > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/Main.java > 1067233 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/AliasMasker.g > PRE-CREATION > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/MacroExpansion.g > PRE-CREATION > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/MacroImport.g > PRE-CREATION > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/ParserUtil.java > PRE-CREATION > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/PigMacro.java > PRE-CREATION > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/QueryParser.g > 1067233 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/scripting/Pig.java > 1067233 > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMacroExpansion.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/400/diff > > > Testing > ------- > > > Thanks, > > Richard > >
