-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/484/
-----------------------------------------------------------
Review request for pig and Richard Ding.
Summary
-------
Currently, the number of fields in the input tuple is determined by the data.
When we have schema, we should generate input data according to the schema, and
padding nulls if necessary.
This addresses bug PIG-1188.
https://issues.apache.org/jira/browse/PIG-1188
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/rules/TypeCastInserter.java
1079597
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestEvalPipeline2.java
1079597
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMergeForEachOptimization.java
1079597
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestMultiQueryCompiler.java
1079597
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanFilterAboveForeach.java
1079597
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanFilterRule.java
1079597
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanLogicalOptimizer.java
1079597
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanPushDownForeachFlatten.java
1079597
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPartitionFilterPushDown.java
1079597
Diff: https://reviews.apache.org/r/484/diff
Testing
-------
test-patch:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 24 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
Unit test:
all pass
End to end test:
all pass
Thanks,
Daniel
