-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/525/
-----------------------------------------------------------
Review request for pig and Xuefu Zhang.
Summary
-------
The following script fail:
a = load '1.txt' as (a0:int, a1);
b = group a by a0;
c = foreach b generate flatten(a);
d = cogroup c by (a0);
e = foreach d generate c.a0 as e0;
f = foreach e generate e0;
describe f;
Error message:
Caused by: Failed to generate logical plan. Nested exception:
org.apache.pig.impl.logicalLayer.FrontendException: ERROR 0: Cannot find field
a0 in a::a0#17:int,a::a1#18:bytearray
at
org.apache.pig.parser.LogicalPlanGenerator.alias_col_ref(LogicalPlanGenerator.java:12835)
at
org.apache.pig.parser.LogicalPlanGenerator.col_ref(LogicalPlanGenerator.java:12697)
at
org.apache.pig.parser.LogicalPlanGenerator.projectable_expr(LogicalPlanGenerator.java:7715)
at
org.apache.pig.parser.LogicalPlanGenerator.var_expr(LogicalPlanGenerator.java:7491)
at
org.apache.pig.parser.LogicalPlanGenerator.expr(LogicalPlanGenerator.java:6904)
at
org.apache.pig.parser.LogicalPlanGenerator.flatten_generated_item(LogicalPlanGenerator.java:5235)
at
org.apache.pig.parser.LogicalPlanGenerator.generate_clause(LogicalPlanGenerator.java:11022)
at
org.apache.pig.parser.LogicalPlanGenerator.foreach_plan(LogicalPlanGenerator.java:10789)
at
org.apache.pig.parser.LogicalPlanGenerator.foreach_clause(LogicalPlanGenerator.java:10670)
at
org.apache.pig.parser.LogicalPlanGenerator.op_clause(LogicalPlanGenerator.java:1280)
at
org.apache.pig.parser.LogicalPlanGenerator.general_statement(LogicalPlanGenerator.java:646)
at
org.apache.pig.parser.LogicalPlanGenerator.statement(LogicalPlanGenerator.java:467)
at
org.apache.pig.parser.LogicalPlanGenerator.query(LogicalPlanGenerator.java:365)
at org.apache.pig.parser.QueryParserDriver.parse(QueryParserDriver.java:64)
This addresses bug PIG-1927.
https://issues.apache.org/jira/browse/PIG-1927
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/PigServer.java
1085235
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/DereferenceExpression.java
1085235
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LogicalSchema.java
1085235
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/ColumnAliasConversionVisitor.java
1085235
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/TypeCheckingExpVisitor.java
1085235
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestEvalPipeline2.java
1085235
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestUnionOnSchema.java
1085235
Diff: https://reviews.apache.org/r/525/diff
Testing
-------
test-patch:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 6 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
Unit-test:
Still need a complete run, though seems no big problem left
Thanks,
Daniel
