[
https://issues.apache.org/jira/browse/PIG-1975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021364#comment-13021364
]
[email protected] commented on PIG-1975:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/622/
-----------------------------------------------------------
Review request for pig and Richard Ding.
Summary
-------
See PIG-1975
This addresses bug PIG-1975.
https://issues.apache.org/jira/browse/PIG-1975
Diffs
-----
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POCast.java
1094799
Diff: https://reviews.apache.org/r/622/diff
Testing
-------
Test-patch:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
No test added since it is impossible to make legacy LoadCaster compile in new
code.
Unit-test:
all pass
Manual test:
Bring a legacy LoadCaster class file and run it over trunk, it succeed.
Thanks,
Daniel
> Need to provide backward compatibility for legacy LoadCaster (without
> bytesToMap(bytes, fieldSchema))
> -----------------------------------------------------------------------------------------------------
>
> Key: PIG-1975
> URL: https://issues.apache.org/jira/browse/PIG-1975
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-1975-1.patch, PIG-1975-2.patch
>
>
> Pig changed LoadCaster interface in 0.9 for typed map (PIG-1876). We change
> bytesToMap(byte[] b, ResourceFieldSchema fieldSchema)
> to
> bytesToMap(byte[] b)
> We should provide backward compatibility for old LoadCaster. If we don't find
> the new bytesToMap, we use the old bytesToMap to convert bytes to map with
> bytearray value. It is still wrong but at least matching the ability of old
> behavior.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
