[
https://issues.apache.org/jira/browse/PIG-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021895#comment-13021895
]
[email protected] commented on PIG-1910:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/624/#review499
-----------------------------------------------------------
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/LineageFindRelVisitor.java
<https://reviews.apache.org/r/624/#comment1029>
If there are multiple group-by columns, the group column will be a tuple.
This will associate the load function only to the tuple and not the uids of the
columns within the tuple.
Need to associated load function to inner-uids as well like its done in
mapMatchLoadFuncToUid
- thejas
On 2011-04-19 21:20:10, Daniel Dai wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/624/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-19 21:20:10)
bq.
bq.
bq. Review request for pig and thejas.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See PIG-1910
bq.
bq.
bq. This addresses bug PIG-1910.
bq. https://issues.apache.org/jira/browse/PIG-1910
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/DereferenceExpression.java
1095145
bq.
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/ExpToPhyTranslationVisitor.java
1095145
bq.
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/ProjectExpression.java
1095145
bq.
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/relational/LOCogroup.java
1095145
bq.
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/ColumnAliasConversionVisitor.java
1095145
bq.
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/LineageFindRelVisitor.java
1095145
bq.
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/visitor/UDFFinder.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/parser/QueryParserDriver.java
1095145
bq.
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPigServer.java
1095145
bq.
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPlanGeneration.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestTypeCheckingValidatorNewLP.java
1095145
bq.
http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/Util.java
1095145
bq.
bq. Diff: https://reviews.apache.org/r/624/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Test-patch:
bq. [exec] +1 overall.
bq. [exec]
bq. [exec] +1 @author. The patch does not contain any @author tags.
bq. [exec]
bq. [exec] +1 tests included. The patch appears to include 12 new or
modified tests.
bq. [exec]
bq. [exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
bq. [exec]
bq. [exec] +1 javac. The applied patch does not increase the total
number of javac compiler warnings.
bq. [exec]
bq. [exec] +1 findbugs. The patch does not introduce any new
Findbugs warnings.
bq. [exec]
bq. [exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
bq.
bq. Unit test:
bq. all pass
bq.
bq.
bq. Thanks,
bq.
bq. Daniel
bq.
bq.
> incorrect schema shown when project-star is used with other projections
> -----------------------------------------------------------------------
>
> Key: PIG-1910
> URL: https://issues.apache.org/jira/browse/PIG-1910
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Thejas M Nair
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-1910-1.patch, PIG-1910-2.patch, PIG-1910-3.patch
>
>
> {code}
> grunt> l = load 'x' ;
> grunt> f = foreach l generate $1 as a, *, $2 as b;
> grunt> describe f;
> f: {a: bytearray,(null),b: bytearray} -- The tuple returned by * is
> automatically flattened, so this schema is not correct. It is more accurate
> to return a null schema.
> {code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
