> On 2011-04-13 18:03:22, Dmitriy Ryaboy wrote: > > trunk/src/org/apache/pig/backend/hadoop/streaming/HadoopExecutableManager.java, > > line 202 > > <https://reviews.apache.org/r/547/diff/1/?file=14980#file14980line202> > > > > Do we care about the specifics of how this output is written? > > > > Seems like it would be less code, and potentially better in the long > > run (if we are dealing with other kinds of splits) to just call toString() > > on the InputSplit. FileSplit already defines its own toString() which > > prints out the path, the start offset, and the length.
I agree with Dmitriy. If possible, we should avoid special casing for a particular type of InputSplit. Further, InputSplit provides getLocations() and getLength() api which should be used instead of FileSplit specific api. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/547/#review452 ----------------------------------------------------------- On 2011-04-04 19:33:32, Adam Warrington wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/547/ > ----------------------------------------------------------- > > (Updated 2011-04-04 19:33:32) > > > Review request for pig. > > > Summary > ------- > > This is a patch for PIG-1702, which describes an issue where the task output > logs for PIG streaming jobs contains null input-split information. The > ability to query the input-split information through the JobConf went away > with the new MR API. We must now gain a reference to the underlying > FiletSplit, and query this reference for that information. > > > Diffs > ----- > > > trunk/src/org/apache/pig/backend/hadoop/streaming/HadoopExecutableManager.java > 1088692 > > Diff: https://reviews.apache.org/r/547/diff > > > Testing > ------- > > > Thanks, > > Adam > >
