[
https://issues.apache.org/jira/browse/PIG-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029577#comment-13029577
]
Daniel Dai commented on PIG-2027:
---------------------------------
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no tests are needed for
this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
Unit-test:
all pass
Manual test:
tested when --l point to a file which don't have write permission
> NPE if Pig don't have permission for log file
> ---------------------------------------------
>
> Key: PIG-2027
> URL: https://issues.apache.org/jira/browse/PIG-2027
> Project: Pig
> Issue Type: Bug
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Priority: Trivial
> Fix For: 0.10
>
> Attachments: PIG-2027-1.patch
>
>
> If specify a log file to Pig, but Pig don't have write permission, if any
> failure in Pig script, we will get a NPE in addition to Pig script failure:
> 2011-05-02 13:18:36,493 [main] ERROR org.apache.pig.tools.grunt.Grunt -
> java.lang.NullPointerException
> at org.apache.pig.impl.util.LogUtils.writeLog(LogUtils.java:172)
> at org.apache.pig.impl.util.LogUtils.writeLog(LogUtils.java:79)
> at
> org.apache.pig.tools.grunt.GruntParser.executeBatch(GruntParser.java:131)
> at
> org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:180)
> at
> org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:152)
> at org.apache.pig.tools.grunt.Grunt.exec(Grunt.java:90)
> at org.apache.pig.Main.run(Main.java:554)
> at org.apache.pig.Main.main(Main.java:109)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
