[ 
https://issues.apache.org/jira/browse/PIG-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054677#comment-13054677
 ] 

Daniel Dai commented on PIG-2139:
---------------------------------

+1. Note this changes the semantic of LogicalPlan.isEqual. Two logical plan 
will never consider equal if they contain non-deterministic UDF. Since we don't 
yet have a use case to compare two logical plan, there is no side effect for 
now.

> LogicalExpressionSimplifier optimizer rule should check if udf is 
> deterministic while checking if they are equal
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: PIG-2139
>                 URL: https://issues.apache.org/jira/browse/PIG-2139
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.8.0, 0.8.1, 0.9.0, 0.10
>            Reporter: Thejas M Nair
>            Assignee: Thejas M Nair
>             Fix For: 0.9.0, 0.10
>
>         Attachments: PIG-2139.1.patch
>
>
> LogicalExpressionSimplifier simplifies filter expressions. In the process, it 
> compares udfs to see if they are 'equal' (ie expected to produce same 
> results). But it does not check if the udfs are annotated as 
> @Nondeterministic. If such an annotation exists, then the udfs should not be 
> considered equal. UserFuncition.isEqual() is being used to compare the udfs.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to