[
https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078605#comment-13078605
]
Daniel Dai commented on PIG-1429:
---------------------------------
Hi, Zhijie, patch in generally looks good. I tested load simple boolean data,
load nested boolean data, cast into boolean, cast into complex boolean, all
works. Here is my review comments:
1. Conversion from string/bytearray -> boolean, only "true" ignore case will
return true, otherwise return false. This is the behavior of Boolean.valueOf. I
am fine with it, not sure how others in community think of
2. Conversion from number -> boolean. Actually I'd like to disable it. If we do
allow it, we need to do consistently. You did it in caster, but
TypeCheckingExpVisitor does not handle it.
3. POCast.java:382, "Note: NOT part of the LoadCaster interface", byteToBoolean
is in interface in patch
4. CastUtil.java: 195, why do we catch NumberFormatException?
5. POCast.java:169, typo:"Cannot determine how to convert the bytearray to int"
6. Tests is not added, right?
> Add Boolean Data Type to Pig
> ----------------------------
>
> Key: PIG-1429
> URL: https://issues.apache.org/jira/browse/PIG-1429
> Project: Pig
> Issue Type: New Feature
> Components: data
> Affects Versions: 0.7.0
> Reporter: Russell Jurney
> Assignee: Zhijie Shen
> Labels: boolean, gsoc2011, pig, type
> Attachments: PIG-1429_1.patch, PIG-1429_2.patch, working_boolean.patch
>
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> Pig needs a Boolean data type. Pig-1097 is dependent on doing this.
> I volunteer. Is there anything beyond the work in src/org/apache/pig/data/
> plus unit tests to make this work?
> This is a candidate project for Google summer of code 2011. More information
> about the program can be found at http://wiki.apache.org/pig/GSoc2011
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
