[
https://issues.apache.org/jira/browse/PIG-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082766#comment-13082766
]
Daniel Dai commented on PIG-1429:
---------------------------------
I was impressed by the completeness of the patch. Good job, Zhijie! The
comments before were properly addressed. There are several more comments:
1. package test.org.apache.pig.test.utils.dotGraph.parser is generated by
javacc, it should not be included in patch
2. I saw in golden files, we already have boolean type in some of the nodes,
except we are using "boolean" instead of "bool". I wonder if we need to change
the name. We can use "boolean" instead of "bool" as the name, thus no backward
compatibility issue
3. Utf8StorageConverter.java:359, the comments here is no longer applicable
4. I don't understand the change in
contrib/zebra/src/java/org/apache/hadoop/zebra/schema/SchemaParser.jjt, why we
add "t = <>"?
5. I don't understand some of the test case you change, if you can give a brief
description each testcase you changed (like TestTypeCheckingValidatorNewLP:test
implicit cast, TestConversions:test bytes<=>boolean conversion), that would
help. Also I don't see any end-to-end tests(something similar to
TestForEachNestedPlanLocal in your nested cross patch). We shall add the
following end-to-end test: read boolean input, read a tuple containing boolean
type, group/order by boolean
> Add Boolean Data Type to Pig
> ----------------------------
>
> Key: PIG-1429
> URL: https://issues.apache.org/jira/browse/PIG-1429
> Project: Pig
> Issue Type: New Feature
> Components: data
> Affects Versions: 0.7.0
> Reporter: Russell Jurney
> Assignee: Zhijie Shen
> Labels: boolean, gsoc2011, pig, type
> Attachments: PIG-1429_1.patch, PIG-1429_2.patch, PIG-1429_3.patch,
> working_boolean.patch
>
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> Pig needs a Boolean data type. Pig-1097 is dependent on doing this.
> I volunteer. Is there anything beyond the work in src/org/apache/pig/data/
> plus unit tests to make this work?
> This is a candidate project for Google summer of code 2011. More information
> about the program can be found at http://wiki.apache.org/pig/GSoc2011
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
