----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1600/#review1560 -----------------------------------------------------------
trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POProject.java <https://reviews.apache.org/r/1600/#comment3532> The variable should be declared after the null check. If the null check is false then the variable is never used. - Santhosh On 2011-08-19 19:54:30, Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1600/ > ----------------------------------------------------------- > > (Updated 2011-08-19 19:54:30) > > > Review request for pig and thejas. > > > Summary > ------- > > See PIG-2185 > > > This addresses bug PIG-2185. > https://issues.apache.org/jira/browse/PIG-2185 > > > Diffs > ----- > > > trunk/src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POProject.java > 1159433 > trunk/test/org/apache/pig/test/TestEvalPipeline2.java 1159433 > > Diff: https://reviews.apache.org/r/1600/diff > > > Testing > ------- > > test-patch pass: > [exec] +1 overall. > [exec] > [exec] +1 @author. The patch does not contain any @author tags. > [exec] > [exec] +1 tests included. The patch appears to include 3 new or modified > tests. > [exec] > [exec] +1 javadoc. The javadoc tool did not generate any warning messages. > [exec] > [exec] +1 javac. The applied patch does not increase the total number of > javac compiler warnings. > [exec] > [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. > [exec] > [exec] +1 release audit. The applied patch does not increase the total number > of release audit warnings. > > Unit tests pass. > > > Thanks, > > Daniel > >
