----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1929/#review1974 -----------------------------------------------------------
trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/CombinerOptimizer.java <https://reviews.apache.org/r/1929/#comment4462> I think a comment will be useful - // The algebraic udf can have more than one input. Add the udf only once trunk/src/org/apache/pig/builtin/COR.java <https://reviews.apache.org/r/1929/#comment4463> The size of the tuple would need to be size*(size-1). Details - the inner loop is executed - (n-1) + (n-2) + .. (n - (n-1)) = n(n-1)/2 . Each time the inner loop is executed two columns are being added. So 2 * n(n-1)/2 = n(n-1) trunk/src/org/apache/pig/builtin/COR.java <https://reviews.apache.org/r/1929/#comment4464> I don't understand why the values are being added to a tuple as columns. That does not look right. - Thejas On 2011-09-16 18:11:08, Daniel Dai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1929/ > ----------------------------------------------------------- > > (Updated 2011-09-16 18:11:08) > > > Review request for pig and Thejas Nair. > > > Summary > ------- > > See PIG-2286 > > > This addresses bug PIG-2286. > https://issues.apache.org/jira/browse/PIG-2286 > > > Diffs > ----- > > trunk/src/org/apache/pig/builtin/COR.java 1171325 > > trunk/src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/CombinerOptimizer.java > 1171325 > trunk/test/e2e/pig/tests/nightly.conf 1171325 > > Diff: https://reviews.apache.org/r/1929/diff > > > Testing > ------- > > Unit-test: > all pass > > Piggybank-test: > TestDBStorage fail for other reason, unrelated to patch > > Test-patch: > [exec] +1 overall. > [exec] > [exec] +1 @author. The patch does not contain any @author tags. > [exec] > [exec] +1 tests included. The patch appears to include 3 new or > modified tests. > [exec] > [exec] +1 javadoc. The javadoc tool did not generate any warning > messages. > [exec] > [exec] +1 javac. The applied patch does not increase the total > number of javac compiler warnings. > [exec] > [exec] +1 findbugs. The patch does not introduce any new Findbugs > warnings. > [exec] > [exec] +1 release audit. The applied patch does not increase the > total number of release audit warnings. > > > Thanks, > > Daniel > >
