[ 
https://issues.apache.org/jira/browse/PIG-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121391#comment-13121391
 ] 

Alan Gates commented on PIG-2245:
---------------------------------

Tests run fine.  The only question I have is did you really mean to pass the 
second column to TOKENIZE?  In the file reg1459894 the first field is a random 
string of characters and numbers and the second field is a random Greek letter 
name.  This second field, which you're passing, shouldn't ever have a 9 in it, 
so the second test shouldn't be a no-op.  Likewise the first test is a no-op 
since $1 will also never have a space.  Based on how TOKENIZE works the 'name' 
field from the studenttab10k file might be a better choice since it includes 
spaces.
                
> Add end to end test for tokenize
> --------------------------------
>
>                 Key: PIG-2245
>                 URL: https://issues.apache.org/jira/browse/PIG-2245
>             Project: Pig
>          Issue Type: Test
>          Components: internal-udfs
>    Affects Versions: 0.10
>            Reporter: Ashutosh Chauhan
>            Assignee: Mark Roddy
>         Attachments: pig-tokenize.diff
>
>
> via test harness.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to