[ 
https://issues.apache.org/jira/browse/PIG-2304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171410#comment-13171410
 ] 

Alan Gates commented on PIG-2304:
---------------------------------

Running test-patch gives

{code}
     [exec]
     [exec]
     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no tests are needed for 
this patch.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec]
     [exec]     -1 findbugs.  The patch appears to introduce 1 new Findbugs 
warnings.
     [exec]
     [exec]     -1 release audit.  The applied patch generated 518 release 
audit warnings (more than the trunk's current 511 warnings).
     [exec]
     [exec]
     [exec]
{code}

The release audit issues are a false alarm, but it looks like the findbugs 
issue is real.  Also, a test with a Python UDF that used the system libraries 
should be included, preferably in the e2e tests, to check that this works 
properly.

I'll attach the relevant findbugs log.
                
> Give jython access to site-packages
> -----------------------------------
>
>                 Key: PIG-2304
>                 URL: https://issues.apache.org/jira/browse/PIG-2304
>             Project: Pig
>          Issue Type: Improvement
>            Reporter: Doug Daniels
>            Assignee: Doug Daniels
>            Priority: Minor
>         Attachments: PIG-2304.patch
>
>
> In addition to the standard jython libraries, I'd like to be able to use 
> installed site-packages.  This patch adds site-packages to the jython module 
> search path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to