[
https://issues.apache.org/jira/browse/PIG-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173449#comment-13173449
]
Thejas M Nair commented on PIG-2430:
------------------------------------
bq. Is there a way for us to tell if a UDF was DEFINEd or just used directly?
The information is not currently available in TypeCheckingExpVisitor, but it
should be possible to pass that along. LogicalPlanBuilder.buildUDF is where the
replacement with defined udf happens.
bq. This ambiguity could be why this argument was ignored in the first place,
but given it's there, I think it could be useful in UDFs, we just have to be
clear on the semantics.
I think we can define the semantics as the getArgsToFuncMapping() returns
function with default constructor arguments, which can be overridden by define
statement. I think it makes sense to add this info to the javadoc comments for
getArgsToFuncMapping.
We need to think about how this constructor argument semantics should be
defined with the new EvalFunc interface in PIG-2421.
> An EvalFunc which overrides getArgToFuncMapping with FuncSpec with
> constructor arguments is not properly instantiated with said arguments
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: PIG-2430
> URL: https://issues.apache.org/jira/browse/PIG-2430
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0, 0.10, 0.11
> Reporter: Jonathan Coveney
> Assignee: Jonathan Coveney
> Fix For: 0.9.0, 0.10, 0.11
>
> Attachments: DummySize.patch, PIG2430.patch, PIG2430_1.patch
>
>
> If you override getArgToFuncMapping and any of the FuncSpec's specify
> constructor arguments, those arguments are currently ignored. Thankfully,
> there is a one line fix (it's funny that this has never been run into before,
> but is an). Patch with tests incoming. I assume that this affects 0.10 and
> 0.9 but haven't tested, I was just working with trunk.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
